Skip to content

Conversation

jeffro256
Copy link
Contributor

Moves the core logic for get_block_longhash() into cryptonote_basic library from cryptonote_core. No change in behavior should occur, it's purely a refactoring.

Depends on #9919

Copy link
Contributor

@vtnerd vtnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look acceptable - but why make the change? Is this related to fcmp++ in some way?

@jeffro256
Copy link
Contributor Author

I intend for get_block_longhash() to be usable in BlockchainLMDB to perform database migrations for if we want to integrate #10038. If we don't, it's also just cleaner IMO.

@jeffro256 jeffro256 force-pushed the mv_get_block_longhash branch from 30ad12a to 488bf71 Compare September 7, 2025 14:58
@jeffro256
Copy link
Contributor Author

Rebased to remove #9919 from commit list

@selsta
Copy link
Collaborator

selsta commented Sep 8, 2025

@vtnerd please re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants