Added keyed services support #1148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the tests to Minio.Tests project |
|
Thank you very much for adding the test, but we need one or more "Functional Test(s)" in ../Minio/Minio.Functional.Tests. |
|
@vugarli,
You don't need to remove the tests you've added into Minio.Tests.
Just use the same tests and adapt them to run as functional tests.
…On Mon, Aug 26, 2024 at 12:35 AM Vugar Samadov ***@***.***> wrote:
@ebozduman <https://github.com/ebozduman>
Should I remove the tests from Minio.Tests, and add the same tests to the
../Minio/Minio.Functional.Tests?
—
Reply to this email directly, view it on GitHub
<#1148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3KHDGFIBELJBMTH72SII3ZTLLETAVCNFSM6AAAAABLZHVU72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGU2DEMJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1147
Added simple wrapper around .AddKeyedService