-
Notifications
You must be signed in to change notification settings - Fork 88
Remove adamw implementation variants: adamw_mf and adamw_zero1 #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @SamitHuang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the project's structure and dependencies by eliminating deprecated optimizer implementations and an outdated model example. The changes aim to simplify maintenance and guide users towards current and actively supported features within the repository. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request performs a significant code cleanup by removing the entire stable_diffusion_xl
example, which is no longer maintained. The removal includes unused AdamW optimizer variants (adamw_mf
and adamw_zero1
) and all associated configuration, documentation, and source files. This change is a positive step towards improving code health and reducing maintenance burden. The deletions are extensive but appear to be consistent with the goal of removing an outdated feature. The PR is well-documented and the changes are clear.
dynacrafter / ip adapter / svd / sv3d / t2i_adapter relies on stable diffsion xl, might need modify / delete as well |
What does this PR do?
Related to #1300
Remove for cleaner code since
adamw_mf
andadamw_zero1
are not used anymore.This PR also removes stable diffusion xl which uses
adamw_zero1
, we are not going to maintain this model in master branch since it's out of date. For users who want to access it, they can either 1) use v0.2.0 branch, 2) use the new diffusers implementations referring toexamples/diffusers/text_to_image/train_text_to_image_sdxl.py
. Remove dynamicrafter, ip adapter, svd, sv3d, and t2i_adapter underexamples
for similar reasons.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@vigo999 @zhanghuiyao @CaitinZhao