Updated Calculator Cppwinrt with 0.80.0-preview.1 release #1064
Conversation
anupriya13
changed the title
|
@HariniMalothu17 check if you need to update the yarn.lock file |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Calculator CppWinRT sample project to use React Native Windows version 0.80.0-preview.1, upgrading from the previous 0.78.1/0.79.x versions. The update includes comprehensive changes to project files, dependency versions, and build configurations to align with the new React Native Windows release.
- Updated React Native Windows from 0.79.0 to 0.80.0-preview.1 and related dependencies
- Regenerated project GUIDs and updated Visual Studio solution configuration
- Modified Android build configurations and Gradle wrapper settings
Reviewed Changes
Copilot reviewed 11 out of 38 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Package.appxmanifest | Updated application identity GUIDs and publisher information |
| Calculator.vcxproj | Updated project GUID and React Native Windows version comment |
| Calculator.sln | Regenerated solution with new project GUIDs and reordered configuration sections |
| tsconfig.json | Simplified TypeScript configuration extends path |
| package.json | Updated all React Native and related dependencies to 0.80.x versions |
| gradlew.bat/gradlew | Updated Gradle wrapper execution to use JAR file approach |
| gradle-wrapper.properties | Updated Gradle version from 8.13 to 8.14.1 |
| build.gradle | Updated Kotlin version from 2.0.21 to 2.1.20 |
| MainApplication.kt | Simplified application initialization using new React Native entry point |
| .prettierrc.js | Removed deprecated bracketSameLine and bracketSpacing configuration |
|
|
||
| <Properties> | ||
| <DisplayName>Calculator</DisplayName> | ||
| <PublisherDisplayName>hmalothu</PublisherDisplayName> |
There was a problem hiding this comment.
The publisher name has been changed to a personal identifier 'hmalothu'. For a sample project, this should typically use a generic or organizational identifier rather than a personal name to maintain the sample's generic nature.
Copilot uses AI. Check for mistakes.
| <Properties> | ||
| <DisplayName>Calculator</DisplayName> | ||
| <PublisherDisplayName>hmalothu</PublisherDisplayName> | ||
| <Logo>Assets\StoreLogo.png</Logo> |
There was a problem hiding this comment.
The publisher display name has been changed to a personal identifier 'hmalothu'. For a sample project, this should use a generic or organizational display name to maintain the sample's reusable nature.
Copilot uses AI. Check for mistakes.
| @@ -114,7 +114,7 @@ case "$( uname )" in #( | |||
| NONSTOP* ) nonstop=true ;; | |||
| esac | |||
|
|
|||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | |||
| CLASSPATH="\\\"\\\"" | |||
There was a problem hiding this comment.
The CLASSPATH is set to escaped quotes which will result in an empty classpath. This appears to be incorrect and could cause Gradle execution to fail.
| CLASSPATH="\\\"\\\"" | |
| CLASSPATH="" |
Copilot uses AI. Check for mistakes.
Description
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
Screenshots
Add any relevant screen captures here from before or after your changes.
Microsoft Reviewers: Open in CodeFlow