Skip to content

Conversation

smalis-msft
Copy link
Contributor

22.04 is really old now, let's see if everything works with our already existing 24.04

@smalis-msft smalis-msft requested a review from a team as a code owner October 7, 2025 20:01
@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 20:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates all VMM tests to use Ubuntu 24.04 instead of Ubuntu 22.04. The changes remove references to the older Ubuntu 22.04 server image and replace them with Ubuntu 24.04 across the entire test suite.

Key Changes:

  • Replace all ubuntu_2204_server_x64 references with ubuntu_2404_server_x64 in test configurations
  • Remove Ubuntu 22.04 artifact definitions from the codebase
  • Update flowey pipeline configurations to use the newer Ubuntu version

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vmm_tests/vmm_tests/tests/tests/x86_64/tpm.rs Updated TPM tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/x86_64/storage.rs Updated storage tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs Updated OpenHCL UEFI tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/x86_64.rs Updated x86_64 tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/multiarch/vmgs.rs Updated VMGS tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/multiarch/vmbus_relay.rs Updated vmbus relay tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/multiarch/openhcl_servicing.rs Updated servicing tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/multiarch/ic.rs Updated integration component tests to use Ubuntu 24.04
vmm_tests/vmm_tests/tests/tests/multiarch.rs Updated multiarch tests to use Ubuntu 24.04
vmm_tests/vmm_test_macros/src/lib.rs Removed Ubuntu 22.04 artifact definition and documentation
vmm_tests/vmm_test_images/src/lib.rs Removed Ubuntu 22.04 from known test artifacts
vmm_tests/petri_artifacts_vmm_test/src/lib.rs Removed Ubuntu 22.04 artifact implementation
vmm_tests/petri_artifact_resolver_openvmm_known_paths/src/lib.rs Removed Ubuntu 22.04 path resolution
flowey/flowey_lib_hvlite/src/_jobs/local_build_and_run_nextest_vmm_tests.rs Updated artifact selection logic
flowey/flowey_hvlite/src/pipelines/checkin_gates.rs Updated checkin gate artifacts to use Ubuntu 24.04

@mattkur
Copy link
Contributor

mattkur commented Oct 7, 2025

We've had cases where older kernel versions found bugs in openvmm and openhcl. I'd be reticent to lose this coverage, but I agree that we can trim our per-PR CI time (and developer experience) by doing this. Thoughts on a nightly CI run with additional guest coverage?

@smalis-msft
Copy link
Contributor Author

I'd be open to that. The main thing I'm working towards here is fixing hvsocket and tdx support, both require kernel patches that are not present in our test images today. If I can get this in cleanly there will be a follow up updating even farther.

@smalis-msft smalis-msft enabled auto-merge (squash) October 7, 2025 21:06
Copy link

github-actions bot commented Oct 7, 2025

Copy link

github-actions bot commented Oct 7, 2025

@benhillis
Copy link
Member

We've had cases where older kernel versions found bugs in openvmm and openhcl. I'd be reticent to lose this coverage, but I agree that we can trim our per-PR CI time (and developer experience) by doing this. Thoughts on a nightly CI run with additional guest coverage?

I think this is a good callout, My team is tracking some CI improvements (different host OSs etc) and using different guest OS's for some kind of nightly / non-PR test sounds like a good idea.

Copy link
Member

@benhillis benhillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I've followed up with Sunil about capturing a broader guest os matrix in nightly runs.

@smalis-msft smalis-msft merged commit 0b65537 into microsoft:main Oct 8, 2025
29 checks passed
@smalis-msft smalis-msft deleted the update-ubuntu branch October 8, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants