-
Notifications
You must be signed in to change notification settings - Fork 154
vmm_tests: Update every test to use Ubuntu 24.04 #2112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates all VMM tests to use Ubuntu 24.04 instead of Ubuntu 22.04. The changes remove references to the older Ubuntu 22.04 server image and replace them with Ubuntu 24.04 across the entire test suite.
Key Changes:
- Replace all
ubuntu_2204_server_x64
references withubuntu_2404_server_x64
in test configurations - Remove Ubuntu 22.04 artifact definitions from the codebase
- Update flowey pipeline configurations to use the newer Ubuntu version
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
vmm_tests/vmm_tests/tests/tests/x86_64/tpm.rs | Updated TPM tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/x86_64/storage.rs | Updated storage tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs | Updated OpenHCL UEFI tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/x86_64.rs | Updated x86_64 tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/multiarch/vmgs.rs | Updated VMGS tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/multiarch/vmbus_relay.rs | Updated vmbus relay tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/multiarch/openhcl_servicing.rs | Updated servicing tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/multiarch/ic.rs | Updated integration component tests to use Ubuntu 24.04 |
vmm_tests/vmm_tests/tests/tests/multiarch.rs | Updated multiarch tests to use Ubuntu 24.04 |
vmm_tests/vmm_test_macros/src/lib.rs | Removed Ubuntu 22.04 artifact definition and documentation |
vmm_tests/vmm_test_images/src/lib.rs | Removed Ubuntu 22.04 from known test artifacts |
vmm_tests/petri_artifacts_vmm_test/src/lib.rs | Removed Ubuntu 22.04 artifact implementation |
vmm_tests/petri_artifact_resolver_openvmm_known_paths/src/lib.rs | Removed Ubuntu 22.04 path resolution |
flowey/flowey_lib_hvlite/src/_jobs/local_build_and_run_nextest_vmm_tests.rs | Updated artifact selection logic |
flowey/flowey_hvlite/src/pipelines/checkin_gates.rs | Updated checkin gate artifacts to use Ubuntu 24.04 |
We've had cases where older kernel versions found bugs in openvmm and openhcl. I'd be reticent to lose this coverage, but I agree that we can trim our per-PR CI time (and developer experience) by doing this. Thoughts on a nightly CI run with additional guest coverage? |
I'd be open to that. The main thing I'm working towards here is fixing hvsocket and tdx support, both require kernel patches that are not present in our test images today. If I can get this in cleanly there will be a follow up updating even farther. |
d31e795
to
8e42dda
Compare
I think this is a good callout, My team is tracking some CI improvements (different host OSs etc) and using different guest OS's for some kind of nightly / non-PR test sounds like a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I've followed up with Sunil about capturing a broader guest os matrix in nightly runs.
22.04 is really old now, let's see if everything works with our already existing 24.04