vmm_tests: use inspect to validate state of the nvme driver
#2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmm_tests: use `inspect` to verify some state of the nvme driver in basic relay
scenarios.
TODO:
- [ ] Move the `child` helper to the `inspect` crate?
- [x] Fix up test failures (test failures are expected at this point, since the
logic isn't solid.
- [ ] Use this technique in more interesting ways.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the vmm_tests framework to use the inspect API for validating NVMe driver state in OpenHCL scenarios. The changes enable testing of specific NVMe device properties through inspection rather than just verifying basic functionality.
Key changes:
- Made the
inspectfunction public in the petri crate for broader testing use - Added helper functions to extract typed values from inspect nodes
- Enhanced NVMe relay tests to validate device properties like save/restore support, queue size, and keepalive settings
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs | Added inspect validation logic and helper functions for NVMe device property testing |
| vmm_tests/vmm_tests/Cargo.toml | Added inspect crate dependency |
| petri/src/vm/mod.rs | Exposed inspect_openhcl method publicly and refactored error handling |
|
These tests will get more useful as we complete other work in this space (especially #2087 and other related work). But, I'd like to start getting the structure of these tests in so that we can use them to do that dev work. |
smalis-msft
reviewed
Oct 7, 2025
smalis-msft
reviewed
Oct 7, 2025
smalis-msft
reviewed
Oct 7, 2025
smalis-msft
reviewed
Oct 7, 2025
smalis-msft
reviewed
Oct 7, 2025
gurasinghMS
reviewed
Oct 8, 2025
gurasinghMS
reviewed
Oct 8, 2025
|
Left 2 nit comments but lgtm otherwise |
smalis-msft
reviewed
Oct 8, 2025
smalis-msft
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
petri: make
inspectpublic, andvmm_tests: use
inspectto verify some state of the nvme driver in basic relay scenarios.TODO:
childhelper to theinspectcrate?