-
Notifications
You must be signed in to change notification settings - Fork 153
disk_nvme: Demote NVMe queues availability message from error to info #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
Thanks for making this change, and congrats on your first PR to OpenVMM, @SrinivasShekar! Welcome to the team :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the logging behavior for NVMe device queue availability failures by demoting certain error messages to info level when hitting hardware resource limits. This reduces noise in logs by distinguishing between actual errors and expected hardware limitations.
- Introduced a new
DeviceError
enum to categorize different types of NVMe device errors - Changed error handling to use
DeviceError
variants instead of genericanyhow::Error
- Modified logging to use info level for
NoMoreIoQueues
errors while keeping other errors at appropriate levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change here!
We just merged an increase in test timeout from 5 minutes to 6 minutes. Give this another try, would you? |
Sure Matt. Let me re-run the CI. |
c333311
to
552336c
Compare
150ac11
to
9cbe691
Compare
Issue:
Currently, when we hit the hardware resources limit for the NVMe device, we log an error message which is a red herring among other NVMe IO queue availability failures.
Ref: #499
Fix:
Demoted the log type to info for cases where we hit the hardware resources limit for the NVMe device.
Validation:
Ran nvme specific tests(subset of vmm_tests) using the successfully built the openHCL binary.