mesh_protobuf: fix clippy errors when used in no_std #2060
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper feature gating for the TimestampOutOfRange error type in the mesh_protobuf crate's time module. The change prevents clippy warnings about unused fields by ensuring the error type is only compiled when the "std" feature is enabled, where it's actually used.
- Gates the
TimestampOutOfRangeerror behind the "std" feature flag
jstarks
previously approved these changes
Oct 1, 2025
|
hmm not quite complete, need to iterate a bit more... |
smalis-msft
previously approved these changes
Oct 2, 2025
chris-oo
changed the title
smalis-msft
reviewed
Oct 2, 2025
| annotation: &'a str, | ||
| } | ||
|
|
||
| #[cfg_attr(not(feature = "std"), allow(dead_code))] |
There was a problem hiding this comment.
expect instead of allow?
There was a problem hiding this comment.
does that work if not all the fields are unused? it's only a few at the bottom.
There was a problem hiding this comment.
Yes, as long as the lint happens once
There was a problem hiding this comment.
sure lemme flip em then...
smalis-msft
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few fields that need to be gated, along with allowing dead code. Otherwise, clippy will complain about a bunch of unused fields.