wip: nvme_test: add flr support to the nvme_test controller #2050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a revert of a revert. Originally the FLR implementation just nuked any existing worker tasks. A direct implication of this approach was that all the input to the worker needed to be cloneable (Including any and all FaultConfiguration). As per discussions in internal teams chats, this approach was flawed because of 2 reasons:
Initially I was under the impression that there is no mechanism to signal FLR completion to the guest, however after further discussion, I found that there is an option for RRS. However, this only works on some guests that support it.
Bottom line here is that we need to rethink how FLRs are being processed and we should gracefully shut down or reset the worker upon FLR request. Keeping this PR here for further discussions on it but will keep it in a draft form until we have a good solution for this.
This reverts commit c02d4f6.