Fix ALDoc missing symbols and XML documentation by including dependencies #1824
+34
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ALDoc action was generating reference documentation with missing symbols and XML documentation not displaying properly. This manifested as:
_MissingTypeSymbol_
instead of actual type namesFor example, this AL procedure:
Would generate documentation showing
_MissingTypeSymbol_
for the parameter type and no XML documentation content.Root Cause
The
GenerateDocsSite
function inBuildReferenceDocumentation.HelperFunctions.ps1
was only passing main application files to ALDoc, ignoring dependency files that were calculated but never used. Without access to dependency symbols, ALDoc couldn't resolve type references or display complete documentation.Solution
Updated the ALDoc build process to include both main apps and their dependencies:
Modified
GenerateDocsSite
function:$allDependencies
parameterUpdated function calls:
GenerateDocsSite
now pass the$allDependencies
parameterChanges
Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.HelperFunctions.ps1
(9 insertions)Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.ps1
(2 changes)Testing
Impact
This fix ensures ALDoc has access to dependency symbols when generating documentation, resolving both the missing type symbols issue and ensuring XML documentation displays properly. The change is backward compatible and maintains existing functionality.
Fixes #883.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
bccontainerhelper-addgd5gzaxf9fneh.b02.azurefd.net
pwsh -Command try { . Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.ps1 -artifacts '.artifacts' -ErrorAction Stop; Write-Host 'Action compilation successful' } catch { Write-Host 'Action compilation failed:' /home/REDACTED/work/AL-Go/AL-Go.Exception.Message }
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.