Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 10, 2025

Problem

The ALDoc action was generating reference documentation with missing symbols and XML documentation not displaying properly. This manifested as:

  1. Missing Type Symbols: Parameter types showing as _MissingTypeSymbol_ instead of actual type names
  2. Missing XML Documentation: AL XML documentation comments not appearing in generated docs

For example, this AL procedure:

/// 
/// Set Statement No. With Year Prefix.
/// Banks reset Statement No. every year. To prevent duplicate Statement No. in BC, we need to add year prefix to Statement No.
/// 
/// <param name="CODAStatement">VAR Record "CODA Statement".
procedure SetStatementNoWithYearPrefix(var CODAStatement: Record "CODA Statement")

Would generate documentation showing _MissingTypeSymbol_ for the parameter type and no XML documentation content.

Root Cause

The GenerateDocsSite function in BuildReferenceDocumentation.HelperFunctions.ps1 was only passing main application files to ALDoc, ignoring dependency files that were calculated but never used. Without access to dependency symbols, ALDoc couldn't resolve type references or display complete documentation.

Solution

Updated the ALDoc build process to include both main apps and their dependencies:

  1. Modified GenerateDocsSite function:

    • Added $allDependencies parameter
    • Combined apps and dependencies when building the package list for ALDoc
    • Added null check for dependencies to avoid errors
  2. Updated function calls:

    • Both calls to GenerateDocsSite now pass the $allDependencies parameter

Changes

  • Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.HelperFunctions.ps1 (9 insertions)
  • Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.ps1 (2 changes)

Testing

  • All existing tests pass (3/3)
  • Function signature correctly accepts new parameter
  • Dependencies are now included in ALDoc package list
  • Logic correctly combines apps and dependencies
  • Changes are minimal and surgical (11 insertions, 2 deletions)

Impact

This fix ensures ALDoc has access to dependency symbols when generating documentation, resolving both the missing type symbols issue and ensuring XML documentation displays properly. The change is backward compatible and maintains existing functionality.

Fixes #883.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • bccontainerhelper-addgd5gzaxf9fneh.b02.azurefd.net
    • Triggering command: pwsh -Command try { . Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.ps1 -artifacts &#39;.artifacts&#39; -ErrorAction Stop; Write-Host &#39;Action compilation successful&#39; } catch { Write-Host &#39;Action compilation failed:&#39; /home/REDACTED/work/AL-Go/AL-Go.Exception.Message } (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Deploy Reference Documentation (ALDoc) action missing symbols and xml documentation not showing Fix ALDoc missing symbols and XML documentation by including dependencies Jul 10, 2025
@Copilot Copilot AI requested a review from mazhelez July 10, 2025 07:27
Copilot finished work on behalf of mazhelez July 10, 2025 07:27
spetersenms
spetersenms previously approved these changes Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy Reference Documentation (ALDoc) action missing symbols and xml documentation not showing
3 participants