Skip to content

Conversation

@mslarae13
Copy link
Contributor

@mslarae13 mslarae13 commented Oct 8, 2025

Closes microbiomedata/issues#413

  • Consolidates the jgi-mg, jgi-mt, and emsl .yaml files into 1 user facility .yaml.
  • Add a slot to capture DNA extraction method for long read sequences & differentiate short (MG) from long (MG-LR)
  • Remove slots that NMDC doesn't need to store. These exist in the submission-schema & do not need to be stored by NMDC

@mslarae13 mslarae13 linked an issue Oct 8, 2025 that may be closed by this pull request
4 tasks
@mslarae13 mslarae13 self-assigned this Oct 8, 2025
pkalita-lbl

This comment was marked as resolved.

@mslarae13

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2662/

Built to branch gh-pages at 2025-10-20 19:21 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@mslarae13 mslarae13 marked this pull request as ready for review October 10, 2025 22:26
@ssarrafan
Copy link
Collaborator

pinged Mark to review

@turbomam
Copy link
Member

Apologies for my slow response. Is it fair to say that src/schema/portal_user_facility.yaml consists of both

  • a consolidation of schema elements from other src/schema/portal_*.yaml files
  • some new elements that are related to long-read metagenomics?

Does anyone have a sense of the best way for me to see the new elements?

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments that I would consider of medium importance.

Are we going to capture these values in MongoDB? If not, could these slots be defined in the submission schema?

recommended: true
deprecated: true; as of 2025-10-10, NMDC doesn't need to store this JGI metadata slot & it's now captured directly in the submission portal schema to support submissions
dna_lr_isolate_meth:
description: Describe the method/protocol/kit used to extract DNA/RNA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to ask for the description to say something about the goal of extracting DNA fragments of a certain length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These slots will be captured in mongoDB. That's why I've added them here and removed the ones that are submission portal only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we won't have records for this slot, it shouldn't be in nmdc-schema.
The information this slot is meant to capture would go on Class: Extraction
Should still update this description to clarify this if the long-read extraction method.

mslarae13 and others added 4 commits October 20, 2025 10:25
Removed string_serialization from several fields and added range for emsl_store_temp, project_id, and replicate_number. Updated deprecation notes for certain metadata slots.
Updated description for dna_lr_isolate_meth to specify long read sequencing.
@mslarae13
Copy link
Contributor Author

Additional changes to these slots to be addressed
#2682

@mslarae13 mslarae13 merged commit 61de90e into main Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop Pacbio for NMDC submission

4 participants