-
Notifications
You must be signed in to change notification settings - Fork 9
Add slot to capture long read sequencing DNA extraction method #2662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
|
pinged Mark to review |
|
Apologies for my slow response. Is it fair to say that
Does anyone have a sense of the best way for me to see the new elements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments that I would consider of medium importance.
Are we going to capture these values in MongoDB? If not, could these slots be defined in the submission schema?
src/schema/portal_user_facility.yaml
Outdated
| recommended: true | ||
| deprecated: true; as of 2025-10-10, NMDC doesn't need to store this JGI metadata slot & it's now captured directly in the submission portal schema to support submissions | ||
| dna_lr_isolate_meth: | ||
| description: Describe the method/protocol/kit used to extract DNA/RNA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to ask for the description to say something about the goal of extracting DNA fragments of a certain length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These slots will be captured in mongoDB. That's why I've added them here and removed the ones that are submission portal only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we won't have records for this slot, it shouldn't be in nmdc-schema.
The information this slot is meant to capture would go on Class: Extraction
Should still update this description to clarify this if the long-read extraction method.
Removed string_serialization from several fields and added range for emsl_store_temp, project_id, and replicate_number. Updated deprecation notes for certain metadata slots.
Updated description for dna_lr_isolate_meth to specify long read sequencing.
|
Additional changes to these slots to be addressed |
Closes microbiomedata/issues#413
submission-schema& do not need to be stored by NMDC