Skip to content

Conversation

@jp-bennett
Copy link
Contributor

Radiolib includes the lora.getFrequencyError() function to return the offset from expected frequency center. This can be added to meshpacket and used to help debug mesh problems.

@jp-bennett jp-bennett requested a review from thebentern October 14, 2025 14:36
@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
❌ failed (0)🚫 cancelled🚫 cancelled🚫 cancelledOct 14, 2025, 2:37 PM

@thebentern thebentern requested a review from GUVWAF October 14, 2025 14:38
@GUVWAF
Copy link
Member

GUVWAF commented Oct 14, 2025

I'll reiterate my comments on Discord.
I don't think it's worth saving this in the MeshPacket as it will lead to increased RAM usage quite a lot (~5 bytes per packet in the Tx queue, phone queue, etc.).
The value is also very hard to interpret. It can be that the transmitter is off, the receiver, or both. And you’ll not get a value when you didn’t receive the packet. Lastly, it may be that the error is small, but it’s drifting too much during the packet.

It might be worth recording a max. deviation or latest deviation in the LocalStats, or just only printing it in the logs.

@jp-bennett
Copy link
Contributor Author

Currently plan is to add this value to the log as a debug message, and if it proves to be extremely useful, come back and possibly add to meshpacket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants