Remove the up/down shortcut to launch canned messages #8370
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-bennett
added
enhancement
thebentern
reviewed
Oct 16, 2025
| return handleEmotePickerInput(event); | ||
|
|
||
| case CANNED_MESSAGE_RUN_STATE_INACTIVE: | ||
| if (isSelect) { |
There was a problem hiding this comment.
Do we know what exactly this was doing?
There was a problem hiding this comment.
I believe while in the module screen on an inactive state, it was preventing the select button from mistakenly moving you out of the screen since select is also used to pull action menu. It was intercepting it so it did nothing.
There was a problem hiding this comment.
Basically correct. It was a short circuit to make sure the select button didn't do anything, and that event got passed into the screen handler.
fifieldt
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By request, remove the up/down shortcut launching canned messages.