Fix for using short and long names starting with char "0" from userPrefs.jsonc #8290
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour before this commit was causing an error when using a string starting with character '0' in userPrefs.jsonc as node long or short name.
This was because all strings not quoted starting with 0 are interpreted as octal values so we couldn't use any number above 7 and also no alphabetic characters at all
when using for example:
in
userprefs.jsonc
file.This should fix it, probably it would be nice to check if similar problems are caused by similar declarations in userPrefs.jsonc file