-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Revert cross-preset default-key bridging with UDP and disable UDP by default #8130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas, I've also seen these conversations. We need to talk more before we can have nice things :)
That PR was merely such that if you have nodes on two different presets with the default key, you will be able to decrypt those packets. Bridging happens automatically as UDP is a common medium (except when you set the rebroadcast mode to IMO we should reconsider whether UDP should be enabled by default. |
Indeed. I added "default-key" to the title and removed the enabled by default. |
Hmm, but why do we need to revert the decryption logic if it still creates the same traffic, just not visible? Maybe it makes sense to put it back after #8134? |
Yeah I think so. I'll cherry pick that change over. |
Sending faster preset data to slower ones is bad. |
Yes, it's definitely not a long-term solution, but mostly for meshes where the majority already moved to a faster preset and are trying to get the remaining nodes over. My point is, however, that currently people may already bridge it, but it happens to be invisible because of non-matching channel hashes. |
I would like to be able to bridge LF and MF for the purpose of migration. |
It quickly became apparent based on conversations with users on the discord that this feature is extremely controversial and needs to be removed.
Reverts #7753