Fix CI build for macos by removing cmake installation from brew #13369
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tall-dependencies-osx.sh script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI build for MacOS by removing cmake installation from brew
Description
I noticed that recently all the github actions building for MacOS are failing at the moment of
.dmgfile creation. By deeper inspection I have found that in theInstall Dependenciesstage we runbrew install cmake ... create-dmg. This command fails (see the screenshot from the latest MacOS build action from master attached below) as cmake is already installed fromlocal/pinned tap.Thus
create-dmg(as well as some other packages) is not installed leading to cmake trying to install thecreate-dmginCreateMacDMG.cmake, which fails. I haven't checked why theCPMAddPackagefails there, but I guess, this is an issue with CMake version 4.4.1.By removing the
cmakefrombrew installcommand, rest of the listed packages get installed, and workflow finishes successfully.Test Steps
Trigger MacOS build github action in master branch
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.