Skip to content

Subgrids layout #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Subgrids layout #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2af57a
Make the header sticky to fix scroll issues in safari
thibaultamartin Apr 30, 2025
1111d27
Make the body a grid, that always fills the screen
thibaultamartin Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions sass/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ html {

body {
margin: 0;
min-height: 100svh;
display: flex;
flex-direction: column;
min-height: 100dvh;
display: grid;
grid-template-rows: auto 1fr auto;
background-color: #fff;
color: var(--color-text);

Expand All @@ -52,11 +52,6 @@ body {
line-height: 1.75;
}

main {
flex: 1;
padding-top: var(--navbar-height);
}

a {
color: var(--color-link);
text-decoration: none;
Expand Down
8 changes: 5 additions & 3 deletions sass/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
.site-header {
position: fixed;
position: sticky;
inset-block-start: 0;
inset-inline: 0;

z-index: 1000;
--header-padding: 1.5dvw;
--header-vertical-padding: 8px;

display: flex;
width: 100%;
height: var(--navbar-height);
padding-left: 20px;
align-items: center;
Expand Down Expand Up @@ -189,7 +191,7 @@
border-radius: 6px;
padding-inline: 1rem;
padding-block: 0.75rem;

display: flex;
flex-direction: column;

Expand Down