-
Notifications
You must be signed in to change notification settings - Fork 14
Add method to infer minimum compatible SSSOM version. #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gouttegd
wants to merge
8
commits into
mapping-commons:master
Choose a base branch
from
gouttegd:infer-minimum-version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b139c26
Add method to infer minimum compatible SSSOM version.
gouttegd 9006607
Add missing return type hints.
gouttegd 20ea4e8
Misc fixes.
gouttegd 588bf4f
Use constants to refer to SSSOM slot names.
gouttegd a77d6a1
Merge branch 'master' into infer-minimum-version
gouttegd 28a2354
Add missing type annotation.
gouttegd f419fba
Manipulate version numbers as tuples.
gouttegd b690800
Remove dead code.
gouttegd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there no other theoretical scenarions the "AttributeError" is thrown in the try block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No realistic one.
AttributeError
is thrown when trying to access an attribute that doesn’t exist.Which attribute are we trying to access here?
self.view
: this one has to exist, it is defined a few lines above in the same file.self.view.induced_slot
: This field is defined in LinkML’sSchemaView
class, of whichself.view
is an instance.slot.annotations
: This field is defined in LinkML’sSlotDefinition
class, of whichslot
(as returned by the function above) should be an instance – if it is not, then there must be a pretty serious bug in LinkML.slot.annotations.added_in
: This is the field that may not exist, if the slot we are looking at is not tagged with aadded_in
annotation in the LinkML model.slot.annotations.added_in.value
: If theadded_in
field exists, then it should always have this field – again, if it does not, then something is wrong with LinkML.