chore(logic): Runner should be removed before termination #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbas
added a commit
to flox/ec2-github-runner
that referenced
this pull request
Sep 28, 2023
The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated. machulav#161
garbas
added a commit
to flox/ec2-github-runner
that referenced
this pull request
Oct 10, 2023
The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated. machulav#161
|
definitely the correct way to do it, why it wasn't merged 😢 |
|
oh i see the comments, gh.remove() will mark it unschedulable, aha. PRs remain open, should be just closed if the fix is not relevant anymore 🙃 |
dcarley
pushed a commit
to flox/ec2-github-runner
that referenced
this pull request
Oct 21, 2025
The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated. Cherry-pick of: - machulav#161 This seems to be solving the same problem as the `--ephemeral` argument in the preceding commit but I'm deep enough in this yak shave that I don't want to debug which one works better right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated.