Added option to compress/decompress using memory pointers #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odaira Any chance on this one? :) |
|
@merlimat Sorry for the slow process. I'll include this to 1.6.0 once the review is done. |
|
👍 Thanks! |
|
Sorry, I must release 1.6.0 as soon as possible, so let me push this off until 1.7.0. |
|
Any plans on merging this? |
|
+1 Our case is to compress/decompress blocks of memory where both source and destination are allocated with Unsafe.allocateMemory(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In same case it might beneficial to be able to compress/decompress from direct memory buffer that don't necessarily belong to a
ByteBufferinstance.In that case it's possible, in unsafe Java world, to have a long that represent a pointer to a memory location. Passing that through JNI would be the most efficient way to compress that data.