Add x-request-id middleware for all endpoints #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hyeonki Hong <hyeonki.hong@moreh.io>
pierDipi
reviewed
Sep 16, 2025
internal/proxy/proxy.go
Outdated
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| requestID := r.Header.Get(requestHeaderRequestID) | ||
| if requestID == "" { | ||
| requestID = uuid.New().String() |
There was a problem hiding this comment.
New can panic, can we use the NewRandom() version and handle the error accordingly without panics?
There was a problem hiding this comment.
325c27b
Updated it as you suggested.
Signed-off-by: Hyeonki Hong <hyeonki.hong@moreh.io>
pierDipi
reviewed
Sep 18, 2025
Comment on lines
+296
to
+297
|
|
||
| w.Header().Set(requestHeaderRequestID, requestID) |
There was a problem hiding this comment.
Suggested change
| w.Header().Set(requestHeaderRequestID, requestID) |
There was a problem hiding this comment.
if it's unset we set it at line 294
There was a problem hiding this comment.
Line 294 is the request and line 297 is the response. Setting the X-Request-Id on the response makes it easier to find the corresponding traces or logs when encountering 500 or similar errors.
What do you think about keeping it instead of deleting it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use middleware to handle x-request-id for all endpoints. If an x-request-id already exists in the request, it does not generate a new one.