Prevent crash when settings control is enabled in ControlBar
#1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7193449 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Replace `useLayoutContext()` with `useMaybeLayoutContext()` in `useSettingsToggle` to handle cases where `LayoutContext` is not provided, preventing crashes when settings control is enabled in `ControlBar` component. Signed-off-by: Sora Morimoto <sora@morimoto.io>
smorimoto
force-pushed
the
fix-control-bar-settings-crash
branch
from
531ad92 to
7193449
Compare
|
I actually noticed that this also happens with other properties like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ControlBarcomponent would crash whensettings: truewas set in the controls prop, despite being defined in the type definition. This occurred because theSettingsMenuTogglecomponent was usinguseLayoutContext()which throws an error when noLayoutContextis provided.Changed
useLayoutContext()touseMaybeLayoutContext()in theuseSettingsTogglehook to gracefully handle cases whereLayoutContextis not available, preventing the crash and allowing thesettingscontrol to work properly.