Skip to content

Conversation

@rammanoj
Copy link
Contributor

@rammanoj rammanoj commented Oct 20, 2025

📝 Description

What does this PR do and why is this change necessary?

This PR adds the firewall_id field to lkenodepool. LKE-E has support to create a nodepool with existing firewall / update the firewall of existing nodepool. This PR adds the firewall_id support to linodego.

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

  • Create 2 firewalls (firewallA & firewallB)
  • Create a enterprise cluster with the following payload.
	clusterReq := linodego.LKEClusterCreateOptions{
		Label:      "enterprise-cluster",
		Region:     "us-ord",
		K8sVersion: "v1.31.9+lke7",
		Tier:       "enterprise",
		// Enterprise flag not public; contact Linode to enable Enterprise tier
		NodePools: []linodego.LKENodePoolCreateOptions{{
			Type:       "g6-standard-4",
			Count:      3,
			FirewallID: linodego.Pointer(<firewallA-id>),
		}},
	}
  • Ensure the nodes joined the cluster and use the firewall created in step 1.
  • Now, change the firewall using the below API and ensure that it returns a 200.
	_, err := client.UpdateLKENodePool(context.Background(), <cluster-id>, <pool-id>, linodego.LKENodePoolUpdateOptions{
		FirewallID: linodego.Pointer(<firewallB-id>),
	})
	if err != nil {
		log.Fatalf("Error updating node pool: %v", err)
	}

How do I run the relevant unit/integration tests?

Run make test-unit TEST_ARGS='-run TestLKENodePool'

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@rammanoj rammanoj marked this pull request as ready for review October 21, 2025 20:55
@rammanoj rammanoj requested a review from a team as a code owner October 21, 2025 20:55
@rammanoj rammanoj requested review from jriddle-linode and vshanthe and removed request for a team October 21, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants