Skip to content

LSPS5 support on ldk-node #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

LSPS5 support on ldk-node #645

wants to merge 1 commit into from
+1,069 −12

Conversation

martinsaposnic
Copy link

No description provided.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 22, 2025 •
edited
Loading

👋 Hi! This PR is now in draft status.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@martinsaposnic martinsaposnic force-pushed the lsps5 branch 2 times, most recently from 4d00cfb to 21f63a4 Compare September 22, 2025 20:49
@TheBlueMatt TheBlueMatt mentioned this pull request Sep 23, 2025
Open
@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will get back to this soon, but probably needs to be based on #650 intermittently.

@martinsaposnic
Copy link
Author

will wait until #650 is merged. converting to draft for now

@martinsaposnic martinsaposnic marked this pull request as draft September 30, 2025 05:36
@tnull tnull changed the base branch from develop to main October 7, 2025 08:52
@tnull
Copy link
Collaborator

tnull commented Oct 7, 2025

We decided to make the develop behavior (tracking more-recent LDK main) the default behavior. With #655 we merged develop into main and now deleted the develop branch. Hence the base branch is changed to main here, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinsaposnic @ldk-reviews-bot @tnull