Skip to content

Add LNURL-auth support #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add LNURL-auth support #637

wants to merge 1 commit into from
+248 −0

Conversation

benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Sep 16, 2025 •
edited
Loading

Implements LNURL-auth (LUD-04) specification for secure, privacy-preserving authentication with Lightning services using domain-specific key derivation.

I used LUD-13 for deriving the keys as this is what most wallets use today.

I was able to auth with stacker.news with this so it works!

@benthecarman benthecarman requested a review from tnull September 16, 2025 20:57
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 16, 2025 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@benthecarman benthecarman force-pushed the lnurl-auth branch 3 times, most recently from 655c1a2 to b4b2f09 Compare September 16, 2025 22:02
@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good I think, one comment.

bindings/ldk_node.udl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also want to expose Node::lnurl_auth in bindings here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added!

@benthecarman benthecarman force-pushed the lnurl-auth branch 2 times, most recently from 4093d9e to 9392684 Compare September 22, 2025 16:01
@benthecarman
Add LNURL-auth support
713af6e 
Implements LNURL-auth (LUD-04) specification for secure, privacy-preserving
authentication with Lightning services using domain-specific key derivation.

I used LUD-13 for deriving the keys as this is what most wallets use
today.
@Camillarhi
Copy link
Contributor

Thanks for this. I also tested this with https://stacker.news and https://satsback.com, and I was authenticated successfully on both.

@tnull tnull changed the base branch from develop to main October 7, 2025 08:53
@tnull
Copy link
Collaborator

tnull commented Oct 7, 2025

We decided to make the develop behavior (tracking more-recent LDK main) the default behavior. With #655 we merged develop into main and now deleted the develop branch. Hence the base branch is changed to main here, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benthecarman @ldk-reviews-bot @Camillarhi @tnull