Skip to content

Generated by liferay-continuous-integration #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generated by liferay-continuous-integration #6563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
##
## DO NOT EDIT THIS FILE.
## DO NOT DELETE THIS FILE.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change from "DO NOT EDIT" to "DO NOT DELETE" could be misleading. The original instruction was clearer because the lines that follow describe a mechanism for overriding properties using a separate file. The new instruction might lead developers to believe that editing this file directly is now acceptable, which could cause their changes to be lost or create conflicts. A more explicit instruction would be better.

## DO NOT EDIT OR DELETE THIS FILE.

##
## To update the properties of this file, create a separate properties file
## named "test.${user.name}.properties" with the properties to overwrite.
Expand Down