chore: update types for react #6191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@bryceosterhaus @ethib137 This LGTM. Let me know if I shouldn't merge it. |
ethib137
reviewed
Oct 23, 2025
There was a problem hiding this comment.
Hey @bryceosterhaus there are a lot of changes that appear to be more than just changing types. Maybe we should have a call to go over briefly what these changes are and why they are necessary?
| > { | ||
| 'aria-label'?: string; | ||
|
|
||
| 'aria-labelledby'?: string; |
There was a problem hiding this comment.
The old type looked like it was requiring either aria-labelledby or aria-label to be included while also not allowing both to be added at the same time. This doesn't look like this will have the same behavior.
| const hasItems = (children?: React.ReactNode) => { | ||
| if (!children) { | ||
| const hasItems = (children?: React.ReactNode | Function) => { | ||
| if (!children || typeof children === 'function') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the dxp migration since dxp uses v18 react types. Lets see what CI says...
Also, we don't necessarily need to merge this here. I can just copy/paste these changes to the dxp migration PR