feat(@clayui/autocomplete): LPD-66883 Adds sticker insetItem before to input groups. #6180
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@pat270 does this also allow us to display the sticker inside the input at the start like the description of the ticket shows? If so, can you make sure to add an example of that? |
|
@ethib137 It doesn't. I'll update this with inset. |
|
@ethib137 I updated this pr with an example of stickers. |
| direction = 'bottom', | ||
| displayType, | ||
| filterKey, | ||
| insetItemBefore, |
There was a problem hiding this comment.
Hey @pat270 we don't want to add new props to the autocomplete for this. We just need to update how the input can be rendered. The autocomplete and other components like it let us pass our own component to be used as the input by using the As prop.
There was a problem hiding this comment.
Thanks @ethib137, this actually sounds much better.
There was a problem hiding this comment.
Great! So we shouldn’t need any changes to autocomplete… likely only changes to input css and maybe some other utility classes.
|
@ethib137 just updated the PR with Storybook and clayui.com examples. Let me know if this is correct.
|
There was a problem hiding this comment.
Hey @pat270 this looks good. Feel free to merge it. I just have the one question I added in the code. If it makes sense to make the change I suggested please do that and then merge this. This is a dependency for CMS stuff so we need to start on a release ASAP. Thanks.
ethib137
changed the title
2 participants
https://liferay.atlassian.net/browse/LPD-66883
@ethib137 I don't think we need to add
insetItemAfter. We can use the classes we use for Picker on the input. Let me know if this works.Edit: I added
insetItemBeforefor stickers