Provide Android targetsdk 35 support in SDL2 #13776
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TargetSdk 35 support: Update Android Gradle Plugin version
|
I believe the minimum SDK is referenced elsewhere as well. Can you check the relevant SDL3 commits to make sure everything is addressed? |
I found this commit: But I don't see anything that isn't covered by this PR. I did also find: That commit changed some areas of the code as well to support "safe" windowing areas on Android. Is this what you were thinking of? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every August, Google Play usually requires a new targetSdk minimum. These changes are what is needed to support it in SDL2, which basically boils down to making sure the appropriate gradle version and Android Gradle Plugin version are used, then ensuring the build.gradle knows which version to target.
A minimum SDK version of 19 is no longer supported, so 21 is used instead.
NOTE: Starting in November, Google Play will require 16-kb page alignment (https://android-developers.googleblog.com/2025/05/prepare-play-apps-for-devices-with-16kb-page-size.html), but apparently that support comes along for free if you are using NDK r28c or newer, according to this revert: 6981522