update cross-compile oldstable debian to stable(trixie) #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to running the distro provided rustup runtime fixing the issue of failing to build using native-tls.
tomodachi
commented
Oct 29, 2025
Comment on lines
-18
to
-20
| RUN echo "deb http://deb.debian.org/debian bookworm main" > /etc/apt/sources.list && \ | ||
| echo "deb http://deb.debian.org/debian bookworm-updates main" >> /etc/apt/sources.list && \ | ||
| echo "deb http://deb.debian.org/debian-security bookworm-security main" >> /etc/apt/sources.list |
There was a problem hiding this comment.
The upstream image already contains the correct repository file both in the old Bookworm and Trixie image so no idea what this duplication is added.
It's not needed and triggers a warning in APT so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly so we can cross-compile to the stable Debian Trixie changing from old-stable (Bookworm)
It seems using native-tls was broken in the previous build container.
Since debian trixie provides rustup in the repositories I switch to running that which fixes the issue of failing to build using native-tls.
I tested building towards all the targets in the Dockerfile and compilation was successful and actually tested the binary itself on aarch64-unknown-linux-gnu, since that's what I'm running