Skip to content

always set this.pageCount #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

always set this.pageCount #5

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5b46d5
allways set this.pageCount
ksti Sep 20, 2016
5af4ea0
when componentDidUpdate you should compare prevProps.pageDataArray.le…
ksti Sep 20, 2016
acf834e
if initialPage changed , then scroll to nextProps.initialPage
ksti Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/ViewPager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export default class ViewPager extends Component {
}
}

componentDidUpdate() {
componentDidUpdate(prevProps, prevState) {
if (!this.initialPageSettled) {
this.initialPageSettled = true;
if (Platform.OS === 'ios') {
Expand All @@ -187,7 +187,7 @@ export default class ViewPager extends Component {
//A trick to solve bugs on Android. Delay a little
setTimeout(this.scrollToPage.bind(this, this.props.initialPage, true), 0);
}
} else if (this.layoutChanged) {
} else if (this.layoutChanged || prevProps.pageDataArray.length !== this.props.pageDataArray.length) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is useful and necessary when pageDataArray changed , for instance , you deleted one photo!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be done in componentWillReceiveProps not in componentDidUpdate

this.layoutChanged = false;
if (typeof this.currentPage === 'number') {
if (Platform.OS === 'ios') {
Expand Down