fix: gracefully cast for numeric flag evaluations #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
approved these changes
Jul 7, 2025
jsonbailey
added a commit
that referenced
this pull request
Jul 7, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.1](0.4.0...0.4.1) (2025-07-07) ### Bug Fixes * gracefully cast for numeric flag evaluations ([#27](#27)) ([7429f28](7429f28)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jason Bailey <jbailey@launchdarkly.com>
|
@chenak-a Thanks for the PR. I made some minor tweaks. This has been released as v0.4.1. |
|
@jsonbailey heads up that the release pipeline is failing, seems to have failed to release 0.4.0 as well |
|
@fpiche Thanks for calling that out. This has been corrected. |
happy to contribute 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Closes open-feature/python-sdk#516
Describe the solution you've provided
The LaunchDarkly Python SDK returns numeric flag values as
Object, without distinguishing betweenintandfloat, which previously led to type mismatch errors in OpenFeature evaluations.This PR introduces a
serialize_valuemethod to gracefully cast returned numeric values to the expected type:inttofloatwhen the flag type isFLOAT.float(when safely castable) tointwhen the flag type isINTEGER.boolis not treated asintorfloat.str,dict,list, andboolvalues untouched if matching.This approach allows compatible numeric values to pass type validation while maintaining correctness and avoiding unnecessary failures, aligning the Python SDK behavior with LaunchDarkly’s handling in other environments.
Describe alternatives you've considered
Additional context