Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 26, 2025

Drop Python 3.8 Support and Add Python 3.13 Support Across LaunchDarkly Python Libraries

Summary

This coordinated effort removes Python 3.8 support and adds Python 3.13 support across 6 LaunchDarkly Python repositories:

  • python-server-sdk-otel
  • python-server-sdk-ai
  • python-eventsource
  • openfeature-python-server
  • hello-python
  • hello-openfeature-python-server

Key Changes:

  • Bumped minimum Python version from 3.8 to 3.9
  • Added Python 3.13 to supported versions (3.9-3.13)
  • Updated README files to reflect new Python version requirements
  • Modified GitHub Actions CI matrices to test Python 3.9-3.13 (removed 3.8)
  • Updated pyproject.toml classifiers and Python version constraints
  • Critical fix: Upgraded Sphinx from ^5.0.0 to ^7.0.0 in python-eventsource to resolve Python 3.13 compatibility issues

This follows the pattern established in the reference commit 02076650064d8a20f792c80cda3249a7aa7e336a from python-server-sdk.

Review & Testing Checklist for Human

  • Verify version bump strategy: Confirm "Release-As" version numbers use major version bumps (not minor) since this is a breaking change that drops Python 3.8 support
  • Test documentation builds: Verify documentation still generates correctly with the Sphinx 7.x upgrade, especially on Python 3.13 environments
  • Validate Python version consistency: Cross-check that Python version references are consistent across README, pyproject.toml, and GitHub Actions files in all 6 repositories
  • Test CI coverage: Confirm CI passes on all newly supported Python versions (3.9-3.13) and that no edge cases were missed
  • Dependency compatibility audit: Check that no other dependencies have compatibility issues with the new Python version constraints

Diagram

graph TB
    subgraph "python-eventsource"
        A[README.md]:::minor-edit
        B[pyproject.toml]:::major-edit
        C[GitHub Actions]:::minor-edit
        D[poetry.lock]:::context
    end
    
    subgraph "python-server-sdk-otel"
        E[README.md]:::minor-edit
        F[pyproject.toml]:::minor-edit
        G[GitHub Actions]:::minor-edit
    end
    
    subgraph "python-server-sdk-ai"
        H[README.md]:::minor-edit
        I[pyproject.toml]:::minor-edit
        J[GitHub Actions]:::minor-edit
    end
    
    subgraph "openfeature-python-server"
        K[README.md]:::minor-edit
        L[pyproject.toml]:::minor-edit
        M[GitHub Actions]:::minor-edit
    end
    
    subgraph "hello-python"
        N[README.md]:::minor-edit
        O[pyproject.toml]:::minor-edit
        P[GitHub Actions]:::minor-edit
    end
    
    subgraph "hello-openfeature-python-server"
        Q[README.md]:::minor-edit
        R[pyproject.toml]:::minor-edit
        S[GitHub Actions]:::minor-edit
    end
    
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF
Loading

Notes

Critical Sphinx Compatibility Fix: The python-eventsource repository required a significant Sphinx upgrade from ^5.0.0 to ^7.0.0 to resolve Python 3.13 compatibility issues. The original Sphinx 1.8.6 (resolved from ^5.0.0 constraint) had "No module named 'pipes'" errors on Python 3.13 since the pipes module was removed. This was the most complex part of the migration and required local testing with Python 3.13 to verify the fix.

Breaking Change Impact: This is a coordinated breaking change across 6 repositories that will require users to upgrade from Python 3.8 to Python 3.9+ to continue receiving updates. The "Release-As" version numbers should reflect major version bumps.

CI Validation: All repositories now pass CI checks on Python 3.9-3.13, with the python-eventsource repository being the last to resolve compatibility issues through the Sphinx upgrade.

Link to Devin run: https://app.devin.ai/sessions/3f70248c29dd4d5eb70be4a05a78ce3a
Requested by: @keelerm84

Release-As: 0.4.0

Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner June 26, 2025 14:37
@devin-ai-integration
Copy link
Contributor Author

Original prompt from mkeeler@launchdarkly.com:

SYSTEM:
=== BEGIN THREAD HISTORY (in #sdks-python) ===
GitHub (U01V5FFUQ1E): 

[launchdarkly/python-server-sdk] Pull request merged by keelerm84

Matthew Keeler (U02FZSQUVCL): <@U0915543DJ7> if you look at sha 02076650064d8a20f792c80cda3249a7aa7e336a from the python-server-sdk repository, you will see a commit where I've dropped python 3.8 support from one of our libraries. I also increased testing support up to 3.13.

I need you to make the same type of changes across multiple different repositories:

• <https://github.com/launchdarkly/python-server-sdk-otel>
• <https://github.com/launchdarkly/python-server-sdk-ai>
• <https://github.com/launchdarkly/python-eventsource>
• <https://github.com/launchdarkly/openfeature-python-server>
• <https://github.com/launchdarkly/hello-python>
• <https://github.com/launchdarkly/hello-openfeature-python-server>
For each of these repositories we want to make sure that:

1. We bump the minimum to 3.9.
2. Update the README to reflect this new minimum.
3. Update all github action files to no longer include 3.8.
4. Anywhere we list the versions of python that are supported, we should make sure to expand to include 3.13.
When working on the repositories, you should work under a branch named: mk/sdk-1351/3.8

The PR title should be similar to what you saw in the provided SHA. The commit body should also include a "Release-As: X.Y.Z" designation. That release number should be the next non-breaking version number. For example, if the last tag was 1.2.3, then this should be "Release-As: 1.3.0". Or if it's "0.3.0", it should be "Release-As: 0.4.0".

Matthew Keeler (U02FZSQUVCL): <@U0915543DJ7> see my last message and do that please.

Cursor (U0915543DJ7): <@U02FZSQUVCL> deleted "Update Python support across repositories"

<@U02FZSQUVCL> deleted "Update Python support across repositories"

Matthew Keeler (U02FZSQUVCL): <@U0915543DJ7> help

Cursor (U0915543DJ7): Welcome to Cursor for Slack! Here's how to use it:

Welcome! Here's how to use Cursor in Slack:


*Start an Agent*

Create a new agent to work on your task
```@Cursor [your task description]```

_Example:_ `@Cursor Fix the login bug we discussed in this thread`

:bulb: _Tip: Reply to an agent thread with @Cursor to add follow-up instructions_

*Agent Settings*

View and edit your default model, repository, and branch
```@Cursor settings```

Use a different model, repository, or branch for a single agent
```@Cursor [branch=dev, model=o3, repo=torvalds/linux] Fix the login bug```

*More Commands*


_Cursor agents run in the background and notify you when complete_

Matthew Keeler (U02FZSQUVCL): <@U0915543DJ7> list agents

Cursor (U0915543DJ7): Your Cursor Agents:
• <https://cursor.com/background-agent?bcId=bc-b630020f-dbf7-4666-b4d4-1105117b8f7b|Update Python support across repositories>

_Last 24 hours_

Cursor (U0915543DJ7): Background agent has successfully finished!

Background agent has successfully finished!

*Repository:* `launchdarkly/gonfalon`
*Branch:* `cursor/update-python-support-across-repositories-569b`

Matthew Keeler (U02FZSQUVCL): @Devin I’m sorry. I tried another AI bot but nothing can replace you. :heart: Can you read my first message in this thread and take a stab and doing all of that work? Thanks love!
=== END THREAD HISTORY ===

The latest message is the one right above that tagged you.

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot added the devin-pr Pull request created by Devin AI label Jun 26, 2025
@keelerm84 keelerm84 changed the title feat!: Drop support for Python 3.8 (eol 2024-10-07) feat: Drop support for Python 3.8 (eol 2024-10-07) Jun 26, 2025
@keelerm84 keelerm84 merged commit 026e5d0 into main Jun 26, 2025
13 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1351/3.8 branch June 26, 2025 15:35
keelerm84 pushed a commit that referenced this pull request Jun 26, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](0.3.0...0.4.0)
(2025-06-26)


### Features

* Drop support for Python 3.8 (eol 2024-10-07)
([#25](#25))
([026e5d0](026e5d0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr Pull request created by Devin AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants