-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Drop support for Python 3.8 (eol 2024-10-07) #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-As: 0.4.0 Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
|
Original prompt from mkeeler@launchdarkly.com: |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keelerm84
approved these changes
Jun 26, 2025
keelerm84
approved these changes
Jun 26, 2025
keelerm84
pushed a commit
that referenced
this pull request
Jun 26, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](0.3.0...0.4.0) (2025-06-26) ### Features * Drop support for Python 3.8 (eol 2024-10-07) ([#25](#25)) ([026e5d0](026e5d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Python 3.8 Support and Add Python 3.13 Support Across LaunchDarkly Python Libraries
Summary
This coordinated effort removes Python 3.8 support and adds Python 3.13 support across 6 LaunchDarkly Python repositories:
python-server-sdk-otelpython-server-sdk-aipython-eventsourceopenfeature-python-serverhello-pythonhello-openfeature-python-serverKey Changes:
pyproject.tomlclassifiers and Python version constraintspython-eventsourceto resolve Python 3.13 compatibility issuesThis follows the pattern established in the reference commit
02076650064d8a20f792c80cda3249a7aa7e336afrompython-server-sdk.Review & Testing Checklist for Human
Diagram
graph TB subgraph "python-eventsource" A[README.md]:::minor-edit B[pyproject.toml]:::major-edit C[GitHub Actions]:::minor-edit D[poetry.lock]:::context end subgraph "python-server-sdk-otel" E[README.md]:::minor-edit F[pyproject.toml]:::minor-edit G[GitHub Actions]:::minor-edit end subgraph "python-server-sdk-ai" H[README.md]:::minor-edit I[pyproject.toml]:::minor-edit J[GitHub Actions]:::minor-edit end subgraph "openfeature-python-server" K[README.md]:::minor-edit L[pyproject.toml]:::minor-edit M[GitHub Actions]:::minor-edit end subgraph "hello-python" N[README.md]:::minor-edit O[pyproject.toml]:::minor-edit P[GitHub Actions]:::minor-edit end subgraph "hello-openfeature-python-server" Q[README.md]:::minor-edit R[pyproject.toml]:::minor-edit S[GitHub Actions]:::minor-edit end subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Critical Sphinx Compatibility Fix: The
python-eventsourcerepository required a significant Sphinx upgrade from ^5.0.0 to ^7.0.0 to resolve Python 3.13 compatibility issues. The original Sphinx 1.8.6 (resolved from ^5.0.0 constraint) had "No module named 'pipes'" errors on Python 3.13 since thepipesmodule was removed. This was the most complex part of the migration and required local testing with Python 3.13 to verify the fix.Breaking Change Impact: This is a coordinated breaking change across 6 repositories that will require users to upgrade from Python 3.8 to Python 3.9+ to continue receiving updates. The "Release-As" version numbers should reflect major version bumps.
CI Validation: All repositories now pass CI checks on Python 3.9-3.13, with the
python-eventsourcerepository being the last to resolve compatibility issues through the Sphinx upgrade.Link to Devin run: https://app.devin.ai/sessions/3f70248c29dd4d5eb70be4a05a78ce3a
Requested by: @keelerm84