Skip to content

Conversation

eun2ce
Copy link

@eun2ce eun2ce commented Sep 30, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the sig-node CI configuration to ensure KubeletPSI feature tests continue to run after the feature label is removed in kubernetes/kubernetes#134303.

The change modifies the pull-kubernetes-node-e2e-containerd-kubelet-psi job to include tests with [Feature:KubeletPSI] label in addition to Summary API tests.

This is a companion change to kubernetes/kubernetes#134303, which removes the redundant feature.KubeletPSI label from the test code and replaces it with framework.WithFeatureGate(features.KubeletPSI).

Which issue(s) this PR is related to:

Companion to kubernetes/kubernetes#134303 (partial fix for kubernetes/kubernetes#134172)

Special notes for your reviewer:

This change ensures that when kubernetes/kubernetes#134303 removes the feature.KubeletPSI label from the test code, the CI pipeline will still run the KubeletPSI feature tests through the dedicated job.

The modification changes the focus pattern from --focus="Summary API" to --focus="Summary API|\[Feature:KubeletPSI\]" to include both Summary API tests and any tests with the KubeletPSI feature label.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A - This is a CI configuration change only.

/cc @SergeyKanzhelev

This change updates the pull-kubernetes-node-e2e-containerd-kubelet-psi job
to include tests with [Feature:KubeletPSI] label in addition to Summary API tests.

This is needed to ensure KubeletPSI feature tests continue to run after
the feature label is removed from the test code in kubernetes/kubernetes
PR #134303, which replaces the feature label with framework.WithFeatureGate().

Related to kubernetes/kubernetes#134303
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @eun2ce!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @eun2ce. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eun2ce
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 30, 2025
@SergeyKanzhelev
Copy link
Member

/assign

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: PRs - Needs Reviewer
Development

Successfully merging this pull request may close these issues.

3 participants