-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update sig-node KubeletPSI test focus to include Feature label #35613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This change updates the pull-kubernetes-node-e2e-containerd-kubelet-psi job to include tests with [Feature:KubeletPSI] label in addition to Summary API tests. This is needed to ensure KubeletPSI feature tests continue to run after the feature label is removed from the test code in kubernetes/kubernetes PR #134303, which replaces the feature label with framework.WithFeatureGate(). Related to kubernetes/kubernetes#134303
Welcome @eun2ce! |
Hi @eun2ce. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eun2ce The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the sig-node CI configuration to ensure KubeletPSI feature tests continue to run after the feature label is removed in kubernetes/kubernetes#134303.
The change modifies the
pull-kubernetes-node-e2e-containerd-kubelet-psi
job to include tests with[Feature:KubeletPSI]
label in addition to Summary API tests.This is a companion change to kubernetes/kubernetes#134303, which removes the redundant
feature.KubeletPSI
label from the test code and replaces it withframework.WithFeatureGate(features.KubeletPSI)
.Which issue(s) this PR is related to:
Companion to kubernetes/kubernetes#134303 (partial fix for kubernetes/kubernetes#134172)
Special notes for your reviewer:
This change ensures that when kubernetes/kubernetes#134303 removes the
feature.KubeletPSI
label from the test code, the CI pipeline will still run the KubeletPSI feature tests through the dedicated job.The modification changes the focus pattern from
--focus="Summary API"
to--focus="Summary API|\[Feature:KubeletPSI\]"
to include both Summary API tests and any tests with the KubeletPSI feature label.Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A - This is a CI configuration change only.
/cc @SergeyKanzhelev