Skip to content

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 12, 2025

This PR follows up from #35109 to propagate the config to skip host-level API server availability tests for Azure clusters. The clusters built with CAPZ only expose the control plane via a public load balancer where each node only has an internal IP, so the host-level checks continuously fail and add noise to the logs. e.g. from https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-azure-scalability/1955357052398211072:

W0812 20:35:56.171581   37318 api_availability_measurement.go:83] execservice issue: problem with RunCommand(): output="+ curl --connect-timeout 5 -s -k -w '%{http_code}' -o /dev/null [https://10.0.0.6:443/readyz](https://10.0.0.6/readyz)\ncommand terminated with exit code 7\n", err=exit status 7
W0812 20:35:56.171611   37318 api_availability_measurement.go:86] host 10.0.0.6 not available; HTTP status code:

The changes from #35109 were tested by running the modified presubmit job and none of those logs appear anymore:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5801/pull-cluster-api-provider-azure-load-test-custom-builds/1953910526153068544

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Aug 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nojnhuh
Once this PR has been reviewed and has the lgtm label, please assign marseel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Aug 12, 2025
value: "true"
- name: CL2_API_AVAILABILITY_PERCENTAGE_THRESHOLD
value: "99.99"
# CAPZ clusters don't expose each individual control plane node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please modify the pre-submits the same way and trigger a run on this PR before merging this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35109

The modified test here doesnot run testing/dra/config.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually API server availability isn't even measured for these DRA tests. I removed these changes and kept the one for the non-DRA test.

@nojnhuh nojnhuh force-pushed the azure-scale-apiserver branch from 81ced09 to 0a2344e Compare August 15, 2025 19:03
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2025
@alaypatel07
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2025
@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants