-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Azure scale: Disable host-level API availability checks #35310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
value: "true" | ||
- name: CL2_API_AVAILABILITY_PERCENTAGE_THRESHOLD | ||
value: "99.99" | ||
# CAPZ clusters don't expose each individual control plane node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please modify the pre-submits the same way and trigger a run on this PR before merging this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modified test here doesnot run testing/dra/config.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually API server availability isn't even measured for these DRA tests. I removed these changes and kept the one for the non-DRA test.
81ced09
to
0a2344e
Compare
/lgtm |
This PR follows up from #35109 to propagate the config to skip host-level API server availability tests for Azure clusters. The clusters built with CAPZ only expose the control plane via a public load balancer where each node only has an internal IP, so the host-level checks continuously fail and add noise to the logs. e.g. from https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-azure-scalability/1955357052398211072:
The changes from #35109 were tested by running the modified presubmit job and none of those logs appear anymore:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5801/pull-cluster-api-provider-azure-load-test-custom-builds/1953910526153068544