Add periodic job for signed kubelet serving certs #35255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/config
|
/triage accepted |
k8s-ci-robot
added
the
triage/accepted
BenTheElder
reviewed
Aug 4, 2025
config/jobs/kubernetes/sig-auth/signed-kubelet-server-certs.yaml
Outdated
Show resolved
Hide resolved
g-gaston
force-pushed
the
ci-periodic-job-kubelet-server-certs
branch
2 times, most recently
from
65e25b4 to
8735d2f
Compare
k8s-ci-robot
added
size/L
aramase
reviewed
Aug 21, 2025
config/jobs/kubernetes/sig-auth/signed-kubelet-server-certs.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+14
to
+17
| - org: kubernetes | ||
| repo: kubernetes | ||
| base_ref: master | ||
| path_alias: k8s.io/kubernetes |
There was a problem hiding this comment.
this needs to be set as workdir?
Suggested change
| - org: kubernetes | |
| repo: kubernetes | |
| base_ref: master | |
| path_alias: k8s.io/kubernetes | |
| - org: kubernetes | |
| repo: kubernetes | |
| base_ref: master | |
| path_alias: k8s.io/kubernetes | |
| workdir: true |
There was a problem hiding this comment.
It didn't seem to be required when I tested it, but it does make sense. Changed since it prob doesn't hurt
k8s-ci-robot
added
the
needs-rebase
g-gaston
force-pushed
the
ci-periodic-job-kubelet-server-certs
branch
from
8735d2f to
fab39eb
Compare
k8s-ci-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
g-gaston
force-pushed
the
ci-periodic-job-kubelet-server-certs
branch
from
fab39eb to
cc65e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs all the e2e tests for on-by-default features against a cluster with kubelet server certificates signed by the CP (as opposed to the default self-signed). This way we make sure we exercise certificate validation on any test making exec/logs/port-forward requests.
I tested this locally (with pj on kind) and I got all tests passing except a few ones using volumes. I suspect this is because I'm running "prow" inside a kind cluster and not because of the job's code. I got the same failures when running
ci-kubernetes-e2e-kindlocally.