Support NonPersistent DiskMode and Update Spec - All Required Fields, nodeUUID rename to instanceUUID

[skogta]

What this PR does / why we need it:
This PR does 3 changes to the batch attach spec:

1. Adds DiskMode nonpersistent as VM operator is also going to allow it for traditional VMs being imported into K8s.
2. Makes all fields in the spec required.
3. Changes nodeUUID to instanceUUID (requested by VM op team).

Testing done:
Ran make images.

1. In a batch attach CR, kept on removing 1 after the other fields among (controllerKey, unitNumber, sharingMode, diskMode). Observed that K8s prevented creation of the CR until all fields were populated.
2. Attached a volume to the VM.
3. Detached a volume to the VM.

Precheckin pipelines are not working:
WCP precheckin: https://jenkins-vcf-csifvt.devops.broadcom.net/job/wcp-instapp-e2e-pre-checkin/482/
VKS precheckin: https://jenkins-vcf-csifvt.devops.broadcom.net/view/instapp/job/vks-instapp-e2e-pre-checkin/483/

[k8s-ci-robot]

Hi @skogta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[deepakkinni]

FAILED --- Jenkins Build #482

[deepakkinni]

FAILED --- Jenkins Build #508

[divyenpatel]

/ok-to-test

[divyenpatel]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, skogta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[divyenpatel]

/lgtm cancel

[divyenpatel]

We have offline comment from @lubronzhan

DiskUUID string json:"DiskUUID,omitempty"

The JSON key for DiskUUID should be changed to use lowerCamelCase (diskUUID).

Can you address this in the same PR?

[k8s-ci-robot]

@skogta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-vsphere-csi-driver-verify-golangci-lint	ce052ed	link	true	/test pull-vsphere-csi-driver-verify-golangci-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.