Skip to content

Conversation

@gomesjason
Copy link
Member

@gomesjason gomesjason commented Oct 2, 2025

Is this a bug fix or adding new feature?

Feature

What is this PR about? / Why do we need it?

AWS SDK v1 is no longer being maintained. This change moves us off that SDK.

What testing is done?

  • Validated that a storage other than 1 returns an error
"GRPC error" err="rpc error: code = InvalidArgument desc = storageType INTELLIGENT_TIERING expects storage capacity to be 1Gi"
  • Validated incorrect INTELLIGENT_TIERING parameters bubbles up correct
"GRPC error" err="rpc error: code = Internal desc = Could not create volume... BadRequest: The file system creation request failed because the provided OpenZFSConfiguration was invalid. ReadCacheConfiguration is a required parameter for OpenZFS file systems with StorageType INTELLIGENT_TIERING. To create the file system, resend the request with the ReadCacheConfiguration parameter included.
  • Validated that expand volume on an INTELLIGENT_TIERING filesystem fails
"GRPC error" err="rpc error: code = Unimplemented desc = Storage of StorageType INTELLIGENT_TIERING Filesystem can not be scaled"
  • Dynamically provisioned a DUAL, INTELLIGENT_TIERING filesystem. Validated I could write to it, and it was mounted with IPv6.
  • Ran E2E Tests
  • Validated new error handling
"GRPC error" err=<
        rpc error: code = InvalidArgument desc = Delete Parameters is incorrectly formatted: 1 validation error(s) found.
        - missing required field, DeleteFileSystemInput.OpenZFSConfiguration.FinalBackupTags[0].Key.
 >

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gomesjason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 2, 2025
@gomesjason gomesjason mentioned this pull request Oct 2, 2025
Also bumps other dependencies in the package. By moving to SDK v2, we now have support for INTELLIGENT_TIERING and dual-stack parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants