WIP fix: grpc-generator-image updated; envoy Dockerfile updated #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @kostyay,
thanks a lot for your inspiring gRPC-web introduction at
torq.io.
I am currently working on an update of this tutorial - with an updated gRPC-toolchain.
For that I had to generate a newer and leaner generator multistage docker image (s. grpc_generators and the vue3 app needed also an update (s. code in the frontend folder).
The frontend still fails to run because of an import issue with the grpc-web modules in the Time.vue component (that's why I labeled the issue work-in-progress - WIP).
Once this is fixed, I would be happy, if you like to merge the update into your repo, since it might be useful for many more people and you might gained already some attention.
In case you are familiar with the current grpc-web implementation, I would be very happy, if you could help me fixing the import error in the Time.vue component of the frontend.
Thanks, mark
postscriptum:
You might find the new grpc_generator image useful - I would be happy, if you could test it and give me some feedback there.