-
Notifications
You must be signed in to change notification settings - Fork 8
WIP: Adding New chat button #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nakul-py
wants to merge
4
commits into
jupyterlite:main
Choose a base branch
from
nakul-py:new-chat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import React, { useEffect, useRef } from 'react'; | ||
import { ReactWidget } from '@jupyterlab/apputils'; | ||
import { buildChatSidebar, IChatModel } from '@jupyter/chat'; | ||
import { NewChatButton } from './new-chat-button'; | ||
import { jupyternautLiteIcon } from '../icons'; | ||
|
||
export function buildSidebarWithHeader( | ||
options: Parameters<typeof buildChatSidebar>[0], | ||
newChat: () => void, | ||
model: IChatModel | ||
): ReactWidget { | ||
const sidebar = buildChatSidebar(options); | ||
|
||
const ChatSidebarWithHeader = () => { | ||
const containerRef = useRef<HTMLDivElement>(null); | ||
|
||
useEffect(() => { | ||
if (containerRef.current) { | ||
containerRef.current.innerHTML = ''; | ||
containerRef.current.appendChild(sidebar.node); | ||
sidebar.node.style.flex = '1'; | ||
sidebar.node.style.height = '100%'; | ||
sidebar.update(); | ||
} | ||
}, []); | ||
|
||
return ( | ||
<div style={{ display: 'flex', flexDirection: 'column', height: '100%' }}> | ||
<div | ||
style={{ | ||
padding: '8px', | ||
borderBottom: '1px solid var(--jp-border-color2)' | ||
}} | ||
> | ||
<NewChatButton newChat={newChat} model={model.input} /> | ||
</div> | ||
<div style={{ flex: 1, overflow: 'auto' }} ref={containerRef}></div> | ||
</div> | ||
); | ||
}; | ||
|
||
const widget = ReactWidget.create(<ChatSidebarWithHeader />); | ||
widget.title.icon = jupyternautLiteIcon; | ||
return widget; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
import AddIcon from '@mui/icons-material/Add'; | ||
import React from 'react'; | ||
|
||
import { InputToolbarRegistry, TooltippedButton } from '@jupyter/chat'; | ||
|
||
/** | ||
* Props for the New Chat button. | ||
*/ | ||
export interface INewChatButtonProps | ||
extends InputToolbarRegistry.IToolbarItemProps { | ||
newChat: () => void; | ||
} | ||
|
||
/** | ||
* The new chat button component. | ||
*/ | ||
export function NewChatButton(props: INewChatButtonProps): JSX.Element { | ||
const tooltip = 'Start a new chat'; | ||
return ( | ||
<TooltippedButton | ||
onClick={props.newChat} | ||
tooltip={tooltip} | ||
sx={{ | ||
color: 'var(--jp-ui-font-color1)', | ||
textTransform: 'none', | ||
fontWeight: 'normal', | ||
padding: '2px 4px', | ||
fontSize: '0.75rem', | ||
'&:hover': { | ||
backgroundColor: 'var(--jp-layout-color2)' | ||
} | ||
}} | ||
buttonProps={{ | ||
size: 'small', | ||
variant: 'text', | ||
title: tooltip | ||
}} | ||
> | ||
<span | ||
style={{ | ||
display: 'flex', | ||
alignItems: 'center', | ||
gap: '1px', | ||
fontSize: '1rem' | ||
}} | ||
> | ||
<AddIcon fontSize="small" sx={{ color: 'var(--jp-ui-font-color2)' }} /> | ||
Chat | ||
</span> | ||
</TooltippedButton> | ||
); | ||
} | ||
|
||
/** | ||
* Factory to create the toolbar item for new chat. | ||
*/ | ||
export function newChatItem( | ||
newChat: () => void | ||
): InputToolbarRegistry.IToolbarItem { | ||
return { | ||
element: (props: InputToolbarRegistry.IToolbarItemProps) => { | ||
const newProps: INewChatButtonProps = { ...props, newChat }; | ||
return NewChatButton(newProps); | ||
}, | ||
position: 2000, | ||
hidden: false | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this Icon here because creating chatsidebar with header changes the Jupyterlite icon. So, I use this already created JupyterLite AI chat icon after successfully creating a chatsidebar with a header.
@jtpio and @brichet you have any other way to get back the old icon after rendering chatsidebar? Please share the idea.