fix(swc-angular-plugin): make lifetime explicit in parse_query_prop_info return type #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo return type Rust CI is failing to build jscutlery#802. The function `parse_query_prop_info` returned `AngularPropInfo` with an elided lifetime, while the input `&ClassProp` provided the borrow. This inconsistency triggered the lint. Updated the return type to `AngularPropInfo<'_>` to explicitly tie the lifetime of the returned value to the input borrow, removing the warning and unifying local and CI builds. This makes the lifetime contract explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing CI for: #802
Rust CI is failing to build #802. The function
parse_query_prop_inforeturnedAngularPropInfowith an elided lifetime, while the input&ClassPropprovided the borrow. This inconsistency triggered the lint.Updated the return type to
AngularPropInfo<'_>to explicitly tie the lifetime of the returned value to the input borrow, removing the warning and unifying local and CI builds.This makes the lifetime contract explicit.
Once this is merged the SWC update branch can be rebased and should pass then we can get swc updated!