Fixing file path issue to run on Windows #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source file name is now extracted from editor.getPath() since, eventually, Atom adds othe informational text to the title, so, it was unsafe to use the window title to infer the file name. All backslashes '\\' characters are replaced by forward slashes prior to split the file path and name, this allow the plugin to properly deal with paths in Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin was unable to run on Windows due to an issue with directory separator characters:
These changes fixed the problem.
The source file name is now extracted from editor.getPath() since, eventually, Atom adds other informational text to the title, so, it was unsafe to use the window title to infer the file name. All backslashes '\' characters are replaced by forward slashes '/' prior to split the file path and name, this allow the plugin to properly deal with paths in Windows.