Update README with Expo DevClient rebuild note #19
Conversation
Added note about rebuilding Expo DevClient for library usage.
WalkthroughDocumentation update: Added a note in README under the Expo section indicating that using Expo DevClient for testing requires rebuilding the app. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
36-36: Import path likely incorrect — mismatch with package name.Installation uses
react-native-turbo-mock-location-detector, but the import usesreact-native-mock-location-detector. This will break consumers.-import { isMockingLocation, MockLocationDetectorErrorCode, MockLocationDetectorError } from 'react-native-mock-location-detector' +import { isMockingLocation, MockLocationDetectorErrorCode, MockLocationDetectorError } from 'react-native-turbo-mock-location-detector'
🧹 Nitpick comments (2)
README.md (2)
17-18: Tighten wording and clarify Dev Client requirement; add Expo Go note.Consider a concise rewrite and explicitly call out that Expo Go won’t work.
-If you are using the Expo DevClient for testing your app, then you need to rebuild it in order to make this library work. +If you’re testing with a custom Expo Dev Client (development build), you must rebuild the app for native changes in this library to take effect (e.g., `expo run:ios` / `expo run:android` or an EAS Build with a development profile). Expo Go is not supported.
15-18: Avoid mixed messaging in the Expo section.“Works with no additional config” can be read as contradicting the rebuild requirement. Suggest clarifying that no extra configuration is needed, but a development build is required and must be rebuilt after native changes.
-## Expo -Works with no additional config +## Expo +Works with no additional config, but requires a development build (custom Expo Dev Client). You’ll need to rebuild after native changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~17-~17: Consider a more concise word here.
Context: ...g your app, then you need to rebuild it in order to make this library work. ## Prerequisit...
(IN_ORDER_TO_PREMIUM)
1 participant
Added note about rebuilding Expo DevClient for library usage.
Summary by CodeRabbit