Skip to content

Conversation

@danielgindi
Copy link

No description provided.

@danielgindi danielgindi force-pushed the rtl_keyboard_control branch from 1a803d0 to 3f94722 Compare August 9, 2025 18:38
@josias-r josias-r self-assigned this Aug 14, 2025
@josias-r
Copy link
Owner

Hi @danielgindi thank you for your contribution :) Are you already using this RTL support in a project?

I'm curious if these Buttons are the only place where RTL logic needs to be implemented or if there are other places in Boarding.js that could be affected too

@danielgindi
Copy link
Author

danielgindi commented Aug 14, 2025

Hi @josias-r!
Yes I've just implemented it. The only RTL adjustment I had to do in the code was this (not possible through overriding without some hacks). The other adjustments are in css, and that's user-land in my opinion :)

@danielgindi
Copy link
Author

@josias-r Just making sure you haven't missed my answers

@josias-r
Copy link
Owner

@danielgindi All good, I recieved it, I will come back to this when I fomd the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants