Skip to content

handle response when x-ratelimit-remaining not in headers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

handle response when x-ratelimit-remaining not in headers #26

wants to merge 4 commits into from

Conversation

esonderegger
Copy link

Fixes #25

This PR adds handling for when the response returned from the openFEC API does not contain a X-RateLimit-Remaining header, which happens when the FEC increases your rate-limit.

jwieder
jwieder approved these changes Aug 23, 2018
View reviewed changes
Copy link

@jwieder jwieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm both that this issue occurs as the result of an increased keylimit & that this commit resolves the error.

@esonderegger esonderegger mentioned this pull request May 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jwieder jwieder jwieder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esonderegger @jwieder @RobertTownley