Skip to content

Conversation

janfaracik
Copy link
Member

@janfaracik janfaracik commented Jun 19, 2025

Updated the title and breadcrumb in configure.jelly for consistency:

  • If the page is read only, they now display: 'Configuration'
  • If the page isn't read only, they now display: 'Configure'

Also deleted the Save, Apply, and LOADING keys from Job configure resource bundles in all supported languages, as these are no longer used.

Before
image

After
image

Before
image

After
image

Testing done

  • UI appears as expected

Proposed changelog entries

  • N/A

Proposed changelog category

/label web-ui,skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Deleted the Save, Apply, and LOADING keys from Job configure resource bundles in all supported languages, as these are no longer used. Also updated the breadcrumb title in configure.jelly from 'Configuration' to 'Configure' for consistency.
@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Jun 19, 2025
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incorrect to me.
The breadcrumb to me shows where you are - and you are viewing configuration.

That you may change the configuration by hitting save to me should not change the breadcrumb. Ie the action to get to a page is not the same as the breadcrumb for the page. They are likely to be related but actions would be nouns verbs and pages would be nouns

There is also SystemRead where you would never be performing an action on the actual page.

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Configuration" works for when you're just viewing it (with Job/Extended Read), "Configure" does not.

@janfaracik janfaracik changed the title Rename job breadcrumb from 'Configuration' to 'Configure' Update job config title and breadcrumb depending on read only status Jul 28, 2025
@janfaracik janfaracik requested review from jtnord and daniel-beck July 28, 2025 10:25
@janfaracik
Copy link
Member Author

Thanks - I've updated the PR:

  • If the page is read only, they now display: 'Configuration'
  • If the page isn't read only, they now display: 'Configure'

@jtnord jtnord self-requested a review July 28, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants