-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Update job config title and breadcrumb depending on read only status #10755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update job config title and breadcrumb depending on read only status #10755
Conversation
Deleted the Save, Apply, and LOADING keys from Job configure resource bundles in all supported languages, as these are no longer used. Also updated the breadcrumb title in configure.jelly from 'Configuration' to 'Configure' for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect to me.
The breadcrumb to me shows where you are - and you are viewing configuration.
That you may change the configuration by hitting save to me should not change the breadcrumb. Ie the action to get to a page is not the same as the breadcrumb for the page. They are likely to be related but actions would be nouns verbs and pages would be nouns
There is also SystemRead where you would never be performing an action on the actual page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Configuration" works for when you're just viewing it (with Job/Extended Read), "Configure" does not.
Thanks - I've updated the PR:
|
Updated the title and breadcrumb in configure.jelly for consistency:
Also deleted the Save, Apply, and LOADING keys from Job configure resource bundles in all supported languages, as these are no longer used.
Before

After

Before

After

Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).