Data set q etc #5783
Draft
Data set q etc #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorisGoosen
force-pushed
the
dataSetQEtc
branch
2 times, most recently
from
fb500f7 to
ad91a7c
Compare
JorisGoosen
force-pushed
the
dataSetQEtc
branch
from
472d413 to
35bebe6
Compare
JorisGoosen
force-pushed
the
dataSetQEtc
branch
from
1d86010 to
0c7faef
Compare
make classes make it shorter start moving functionality to their proper place flesh out DataSetQ maak factory functies en ruim datasetpackage alvast beetje op Move label set stuff to ColumnQ from DataSetPackage and some related changes Fairly sure the whol beginLoadingData etc in DataSetPackage isnt really necessary anymore move more stuff to Filter add invalidation to Filter move LabelFilterGenerator to another spot also tightly integrate it with FilterQ etc fix some problems move more stuff from FilterModel to FilterQ cleanin more changes use set functions for deserializen etc stapjes fix errors merge Q classes into the base data classes move labelfiltergenerator to CommonData move some more files around meer fixes add dropped function back fix more things remove lots of _undoStack and more changes JASP compiles again jasp starts try and get the data to show data shows now compiles and mostly runs but complains about threads make sure data classes are moved to the main thread so qml etc can access it later without crying throw in an error ill just add the dataPkgRoles to the rolenames regardles of what each proxy thinks about it variables show up in lists, analyses work filters dont get run, but at least the proxy doesnt choke on it anymore make label editor seem to work again remove useless passtrhough on filtermodel filter shows use invalidation rfilter works labelfiltergenerator is generating once more make sure filter gets updated if constructorR gets changed clarify which labels are from column label order, or dataset order make column selection not crash debug purple! make editable just change visibity instead of the color
…how" through the datamodel
… loading large files tractable again
Next thing to do: Make loading of older jaspfiles actually work. Just like saving and loading
JorisGoosen
force-pushed
the
dataSetQEtc
branch
from
ce3df3a to
ceea99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.