feat(tokens): update tokens usage to reflect UI arquictecture #30678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This reverts commit f33a194.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
This pull request updates the color and background variables across many Ionic component styles to use new design system tokens, improving consistency and maintainability. It also temporarily skips several visual regression tests for the
datetimecomponent due to a known issue (FW-6769).Design Token Migration:
--colorvariables fromglobals.$ion-primitives-neutral-1200toglobals.$ion-text-defaultin components includingcard,card-title,checkbox,chip,datetime,input,item,list-header,radio,searchbar,select,textarea, andtoggle.--backgroundand related background variables fromglobals.$ion-primitives-base-whiteand similar tokens toglobals.$ion-bg-surface-defaultin components includingcard,checkbox,chip,datetime,input,item,radio,segment,select,textarea, andtoggle.Test Suite Maintenance:
datetimecomponent visual regression tests due to issue FW-6769, with TODO comments for future re-enabling ([[1]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-28d032b5dd4c52cbf575dd85894b936c883d43093a03b1e5fca940ee3a626cb3L31-R32),[[2]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-6bcce71748a9d3fff9d03f4829f9ee2f058ff2ff419e5a0168f6b1200e29ba0fL33-R34),[[3]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-6bcce71748a9d3fff9d03f4829f9ee2f058ff2ff419e5a0168f6b1200e29ba0fL87-R89),[[4]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-5c6fab9ab164e203679ae4adfafbc0c4c84c569e8fc37f788f5688707cdd283bL16-R17)).Component-Specific Token Updates:
chip,checkbox, andbuttonsto useglobals.$ion-text-defaultandglobals.$ion-bg-surface-defaultfor improved design alignment ([[1]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-3c751a473bd2fa61cfd77529c7b9e496f34cf198a4aed0bea0b57d1a1f7fe40aL120-R126),[[2]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-796ffc72b6171910c25d5aad085bc245095c38f104d55e253e06282702205066L33-R33),[[3]](https://github.com/ionic-team/ionic-framework/pull/30678/files#diff-efdc0d0b924ff22b22228f52baebe09c69cce416ab33ba4a572c678ba3aa38f8L16-R16)).These changes modernize the component styling to better align with the current design system and improve future maintainability.
There're some snapshots updates that seem to have no visible differences, so I would say its ok to accept the new ones.
Does this introduce a breaking change?