Skip to content

Conversation

cabljac
Copy link
Collaborator

@cabljac cabljac commented Aug 27, 2025

This PR removes the generated SDK from the workspace, so that it doesn't block changesets.

@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 15:22
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: cfe9d4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

docs-page bot commented Aug 27, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~221

Documentation is deployed and generated using docs.page.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request marks the @dataconnect/default-connector package as private within its package.json file. This change ensures the package is not accidentally published to a public registry, indicating it's likely an internal component or not intended for external distribution.

Highlights

  • Package Configuration: The package.json file for the @dataconnect/default-connector package has been updated to include the "private": true field.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copilot

This comment was marked as outdated.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly marks the @dataconnect/default-connector package as private. This is a good practice for internal packages within a monorepo, as it prevents accidental publication. The change is appropriate and well-implemented. I have no further suggestions.

@cabljac cabljac force-pushed the @invertase/force-private branch from 4975e72 to 4ca9beb Compare August 27, 2025 15:22
@cabljac cabljac requested a review from Copilot August 27, 2025 15:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes @dataconnect/default-connector a private package by removing it from the pnpm workspace and changeset tracking while updating all references to use file-based dependencies.

  • Removes @dataconnect/default-connector from workspace packages list
  • Updates all package.json files to use file-based dependency references instead of workspace references
  • Removes the package from changeset ignore list since it's no longer part of the workspace

Reviewed Changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-workspace.yaml Removes dataconnect-sdk/js/* from workspace packages
packages/react/package.json Updates dependency reference to use file path instead of workspace
packages/angular/package.json Updates dependency reference to use file path instead of workspace
examples/react/react-data-connect/package.json Updates dependency reference to use file path instead of workspace
.changeset/config.json Removes @dataconnect/default-connector from ignore list
Files not reviewed (2)
  • packages/react/package-lock.json: Language not supported
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cabljac cabljac merged commit 3c07fab into main Aug 27, 2025
5 checks passed
@cabljac cabljac deleted the @invertase/force-private branch August 27, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant