[SYCL] Remove imf libdevice build warning on Windows #20053
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -73,6 +73,7 @@ if(LLVM_LIBCXX_USED) | |||
| endif() | |||
|
|
|||
| if (WIN32) | |||
| list(APPEND compile_opts "-std=c++17") | |||
There was a problem hiding this comment.
I vaguely remember there being some compilers (especially on Windows) that don't like -std= and prefer /std: instead. Maybe using CXX_STANDARD could address the issue?
There was a problem hiding this comment.
Hi, @steffenlarsen
The libdevice is built with fresh built clang during the compiler building process, so it seems to be OK to use "-std=c++" ?
Thanks very much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler warning reported when building imf libdevice on Windows:
imf_rounding_op.hpp: warning: constexpr if is a C++17 extension [-Wc++17-extensions]
This PR fixes it.